fix: added run recalculation for safe_area when window did become visible #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have a reproduction here? |
Yes, let me attach video. |
|
Wrong safe_area size after background and closing native modal on top. safe_area_after_background.mp4 |
jacobp100
approved these changes
Mar 13, 2024
Closed
1 task
|
Thanks, sorry about the delay merging this! |
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added run recalculation for safe_area when window did become visible
Summary
We found missed scenario when we have to run recalculation for safe_area. In case we open before native modal and then put our app into background mode. After restore it from background and close this modal we see old values for safe_area. We need to run recalculation to cover this scenario.
Native modal partially cover screen and in this case safe_area is reduced a little bit by iOS.